tests/internal/data/opentelemetry/test_cases.json (1)

40-46: Align “missing_timestamp” expectation with current JSON group-body shape.

JSON path doesn’t emit an empty scope when no scope object is present, while other tests (e.g., “valid_basic_log”) also omit it. Recommend removing the empty scope here for consistency.

   "missing_timestamp": {
     "input": {"resourceLogs": [{"scopeLogs": [{"logRecords": [{"body": {"stringValue": "test"}}]}]}]},
     "expected": {
       "group_metadata": {"schema":"otlp","resource_id":0,"scope_id":0},
-      "group_body": {"resource":{},"scope":{}},
+      "group_body": {"resource":{}},
       "log_metadata": {"otlp":{}},
       "log_body": {"log": "test"}
     }
   },

src/opentelemetry/flb_opentelemetry_logs.c (3)

248-274: Emit observed_timestamp when observedTimeUnixNano is an integer too.

Currently metadata emission only handles string type. Accept positive integers as well (spec-compliant and consistent with time resolution above).

-    if (observed_time_unix_nano != NULL && observed_time_unix_nano->type == MSGPACK_OBJECT_STR) {
+    if (observed_time_unix_nano != NULL) {
+        if (observed_time_unix_nano->type == MSGPACK_OBJECT_STR) {
             memset(timestamp_str, 0, sizeof(timestamp_str));
             if (observed_time_unix_nano->via.str.size < sizeof(timestamp_str)) {
                 strncpy(timestamp_str,
                         observed_time_unix_nano->via.str.ptr,
                         observed_time_unix_nano->via.str.size);
             }
             else {
                 strncpy(timestamp_str,
                         observed_time_unix_nano->via.str.ptr,
                         sizeof(timestamp_str) - 1);
             }
-        for (i = 0; i < strlen(timestamp_str); i++) {
+        size_t ts_len = strlen(timestamp_str);
+        for (i = 0; i < ts_len; i++) {
             if (!isdigit((unsigned char) timestamp_str[i])) {
                 timestamp_str[0] = '\0';
                 break;
             }
         }
 
         if (strlen(timestamp_str) > 0) {
             timestamp_uint64 = strtoull(timestamp_str, NULL, 10);
 
             flb_log_event_encoder_append_metadata_values(encoder,
                                                         FLB_LOG_EVENT_STRING_VALUE("observed_timestamp", 18),
                                                         FLB_LOG_EVENT_INT64_VALUE(timestamp_uint64));
         }
-    }
+        }
+        else if (observed_time_unix_nano->type == MSGPACK_OBJECT_POSITIVE_INTEGER) {
+            flb_log_event_encoder_append_metadata_values(encoder,
+                                                         FLB_LOG_EVENT_STRING_VALUE("observed_timestamp", 18),
+                                                         FLB_LOG_EVENT_INT64_VALUE(observed_time_unix_nano->via.u64));
+        }
+    }

---

100-111: Micro: avoid repeated strlen() in loops.

Cache the length once to keep O(n).

-            for (i = 0; i < strlen(timestamp_str); i++) {
+            size_t ts_len = strlen(timestamp_str);
+            for (i = 0; i < ts_len; i++) {

-        for (i = 0; i < strlen(timestamp_str); i++) {
+        size_t ts_len = strlen(timestamp_str);
+        for (i = 0; i < ts_len; i++) {

Also applies to: 260-266

---

242-244: Use the function parameters for metadata key instead of hardcoding.

Preserves flexibility and aligns with the function signature.

-    flb_log_event_encoder_append_metadata_values(encoder,
-                                                 FLB_LOG_EVENT_CSTRING_VALUE(FLB_OTEL_LOGS_METADATA_KEY));
+    flb_log_event_encoder_append_metadata_values(
+        encoder,
+        FLB_LOG_EVENT_STRING_VALUE(logs_metadata_key, logs_metadata_key_len));

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.